remove bounded_vec from fido_common crate

bounded_vec crate was used to enforce constraints on size of various
fields as defined by webauthn or ctap specs. However, it does not
properly support zero-sized lower bounds.
main
Nick Zana 2 years ago
parent c1c95bafc1
commit 8e1b175136

@ -6,9 +6,8 @@ edition = "2021"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
[dependencies] [dependencies]
bounded-vec = { version = "0.7.1", features = ["serde"] }
coset = { version = "0.3.4", default-features = false } coset = { version = "0.3.4", default-features = false }
serde = { version = "1", features = ["derive"], optional = true } serde = { version = "1", features = ["derive"], optional = true }
[features] [features]
serde = ["dep:serde", "bounded-vec/serde"] serde = ["dep:serde"]

@ -1,6 +1,5 @@
use crate::registry::algorithms; use crate::registry::algorithms;
use crate::{authenticator::Transport, credential}; use crate::{authenticator::Transport, credential};
use bounded_vec::BoundedVec;
use std::collections::BTreeSet; use std::collections::BTreeSet;
#[cfg(feature = "serde")] #[cfg(feature = "serde")]
@ -35,7 +34,7 @@ pub struct Descriptor {
/// > A probabilistically-unique byte sequence identifying a /// > A probabilistically-unique byte sequence identifying a
/// > public key credential source and its authentication /// > public key credential source and its authentication
/// > assertions. /// > assertions.
pub id: BoundedVec<u8, 16, 1023>, pub id: Vec<u8>,
/// > This... member contains a hint as to how the client might /// > This... member contains a hint as to how the client might
/// > communicate with the managing authenticator of the public /// > communicate with the managing authenticator of the public
/// > key credential the caller is referring to. /// > key credential the caller is referring to.
@ -64,7 +63,7 @@ pub struct UserEntity {
// //
// WebAuthn says that "The user handle MUST NOT be empty." To maximimize compatibility, the // WebAuthn says that "The user handle MUST NOT be empty." To maximimize compatibility, the
// definition from the CTAP specs is used. // definition from the CTAP specs is used.
pub id: BoundedVec<u8, 0, 64>, pub id: Vec<u8>,
/// > a human-palatable identifier for a user account. It is intended /// > a human-palatable identifier for a user account. It is intended
/// > only for display, i.e., aiding the user in determining the /// > only for display, i.e., aiding the user in determining the
/// > difference between user accounts with similar displayNames. For /// > difference between user accounts with similar displayNames. For

Loading…
Cancel
Save